Repository navigation
Bugfix: selection on wide glyph in scrollback buffer - #1879
Merged
Carlos Zamora (carlos-zamora) merged 1 commit intoJul 10, 2019
Merged
Conversation
Mike Griese (zadjii-msft)
approved these changes
Jul 10, 2019
Michael Niksa (miniksa)
approved these changes
Jul 10, 2019
Wojciech Litewka (mcpiroman)
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 23, 2019
|
🎉 Handy links: |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
I was accidentally looking at the mutable viewport instead of the buffer.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
dir